BeRo1985/flre
1
0
Fork 0
Code Issues 32 Pull requests 9 Projects Releases 1 Packages Wiki Activity Actions

Make Delphi Happy, about those conditionals #86

Open
TommiPrami wants to merge 1 commit from TommiPrami/master into master
pull from: TommiPrami/master
merge into: BeRo1985:master
Conversation 2 Commits 1 Files changed 1 +26 -26
TommiPrami commented 2022-09-02 09:06:48 +00:00 (Migrated from github.com)
Copy link

Can't understand why in earth delphi even cares of second condition because of "{$if defined(fpc) and" should be enough,
If there is plane ">=3" then Delphi complains with :

[dcc32 Warning] FLRE.pas(5493): W1023 Comparing signed and unsigned types - widened both operands

hope this works OK in the FPC also

Can't understand why in earth delphi even cares of second condition because of "{$if defined(fpc) and" should be enough, If there is plane ">=3" then Delphi complains with : [dcc32 Warning] FLRE.pas(5493): W1023 Comparing signed and unsigned types - widened both operands hope this works OK in the FPC also
TommiPrami commented 2022-09-02 09:08:58 +00:00 (Migrated from github.com)
Copy link

It fixes the previous issue I posted: https://github.com/BeRo1985/flre/issues/76

It fixes the previous issue I posted: https://github.com/BeRo1985/flre/issues/76
BeRo1985 commented 2022-11-18 23:12:42 +00:00 (Migrated from github.com)
Copy link

Nope, FPC raises then a error then, at least stable FPC versions, while it seems to be fixed in the non-stable FPC dev version. Thus, I would wait here until FPC >=3.4 as stable version will be released,

Nope, FPC raises then a error then, at least stable FPC versions, while it seems to be fixed in the non-stable FPC dev version. Thus, I would wait here until FPC >=3.4 as stable version will be released,
This pull request has changes conflicting with the target branch.
  • src/FLRE.pas
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin TommiPrami/master:TommiPrami/master
git switch TommiPrami/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff TommiPrami/master
git switch TommiPrami/master
git rebase master
git switch master
git merge --ff-only TommiPrami/master
git switch TommiPrami/master
git rebase master
git switch master
git merge --no-ff TommiPrami/master
git switch master
git merge --squash TommiPrami/master
git switch master
git merge --ff-only TommiPrami/master
git switch master
git merge TommiPrami/master
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BeRo1985/flre!86
No description provided.