BeRo1985/kraft

Fix crash in DoNarrowPhase() after removing TKraftShape that has mesh contact. #33

Closed

and3md wants to merge 1 commit from meshcontacts_fix into master

and3md commented

2023-08-14 12:39:52 +00:00

(Migrated from github.com)

Hi,
I found a crash in Kraft when I have mesh collider and I remove TKraftShape from other rigid body that collides with mesh collider. The fix removes MeshContactPair when we remove contact pair.

Where is the crash exactly?

It crashes in DoNarrowPhase() in the mesh contact pair loop when it get pointer to non-existent TKraftShape and tries get ShapeA.ProxyFatWorldAABB^ (if not AABBIntersect(ShapeA.ProxyFatWorldAABB^,ShapeB.ProxyFatWorldAABB^) then begin)

Hi, I found a crash in Kraft when I have mesh collider and I remove `TKraftShape` from other rigid body that collides with mesh collider. The fix removes MeshContactPair when we remove contact pair. ### Where is the crash exactly? It crashes in `DoNarrowPhase()` in the mesh contact pair loop when it get pointer to non-existent `TKraftShape` and tries get `ShapeA.ProxyFatWorldAABB^` (`if not AABBIntersect(ShapeA.ProxyFatWorldAABB^,ShapeB.ProxyFatWorldAABB^) then begin`)

BeRo1985 commented

2023-08-14 13:15:23 +00:00

(Migrated from github.com)

Applied at github.com/BeRo1985/kraft@c0c81d093a

Applied at https://github.com/BeRo1985/kraft/commit/c0c81d093a1c785730e6bb438ad5891b92e4e307

❤️ 1